-
Notifications
You must be signed in to change notification settings - Fork 11
query-string dependency should not be a peerDependency #32
Comments
Add a dev check to ensure query-string is installed correctly #32
Addressed via #33 by throwing an exception when the wrong version is present. Available in v1.2.3 |
Hey @pbeshai, would you mind explaining your rationale for throwing an exception instead of setting I'm not quite sure I understand why the responsibility of installing this supporting library is pushed to the consumers. Appreciate your work. 🙏 |
Hey, thank you for a very politely worded question! The reason why it's a peer dependency and not a direct dependency is that historically some people needed v5 to support older browsers, while some people wanted v6 to work with newer features. I couldn't get the "you choose your version" to work while listing it as a direct dependency, so I let people choose. I do hope in a new version to make this more obvious / use something like the built-in URLSearchParams as a default, but I need to investigate it more still. |
pbeshai/use-query-params#127
The text was updated successfully, but these errors were encountered: