Merge pull request #38 from vishalvijay/fix_firebase_hosting

Add firebase hosting header

src/index.js

@@ -53,6 +53,11 @@ function getClientIp(req) {
             return req.headers['x-client-ip'];
         }
 
+        // Firebase hosting header (When forwared to cloud function)
+        if (is.ip(req.headers['fastly-client-ip'])) {
+            return req.headers['fastly-client-ip'];
+        }
+
         // Load-balancers (AWS ELB) or proxies.
         const xForwardedFor = getClientIpFromXForwardedFor(req.headers['x-forwarded-for']);
         if (is.ip(xForwardedFor)) {

test/index.js

@@ -77,6 +77,33 @@ test('x-client-ip', (t) => {
     });
 });
 
+test('fastly-client-ip', (t) => {
+    t.plan(1);
+    const options = {
+        url: '',
+        headers: {
+            'fastly-client-ip': '59.195.114.48',
+        },
+    };
+    // create new server for each test so we can easily close it after the test is done
+    // prevents tests from hanging and competing against closing a global server
+    const server = new ServerFactory();
+    // node listens on a random port when using 0
+    // http://stackoverflow.com/questions/9901043/how-does-node-js-choose-random-ports
+    server.listen(0, serverInfo.host);
+    server.on('listening', () => {
+        // we can't make the request URL until we get the port number from the new server
+        options.url = `http://${serverInfo.host}:${server.address().port}`;
+        request(options, (error, response, found) => {
+            if (!error && response.statusCode === 200) {
+                // make sure response ip is the same as the one we passed in
+                t.equal(options.headers['fastly-client-ip'], found);
+                server.close();
+            }
+        });
+    });
+});
+
 test('x-forwarded-for', (t) => {
     t.plan(1);
     const options = {