Add settings options and overlay buttons #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd setting for refresh interval
Open
pboutin
approved these changes
Jul 28, 2020
| @@ -48,5 +45,16 @@ const refreshChaosRecipe = async () => { | |||
| }; | |||
|
|
|||
| ipcRenderer.on('forceChaosRecipeRefresh', () => refreshChaosRecipe()); | |||
| setInterval(() => refreshChaosRecipe(), POLLING_DELAY); | |||
| setInterval(() => refreshChaosRecipe(), settings.get('overlay.refreshTime') * 1000 || 60000); | |||
There was a problem hiding this comment.
I would keep a DEFAULT_REFRESH_TIME constant, so we can do
(settings.get('overlay.refreshTime') || DEFAULT_REFRESH_TIME) * 1000
There was a problem hiding this comment.
Nice idea, it's more user friendly like this :)
I don't know why I can't commit on this change, so if u can do it that's nice :)
Labels for overlay sizes Co-authored-by: Pascal Boutin <contact@pboutin.net>
Constant for refresh time Co-authored-by: Pascal Boutin <contact@pboutin.net>
Apply labels for overlay sizes in html Co-authored-by: Pascal Boutin <contact@pboutin.net>
|
Will merge and apply the final tweaks on master directly, thanks for the contribution ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added buttons in overlay to reopen settings window and force refresh of tabs.
Added settings to customize interval between refresh and change the size of the overlay.
