-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: add happi search widget from atef #246
Conversation
7c2f427
to
1be67f6
Compare
(Rebasing on happi master; less because I want to work on this PR and more because I want to see the effect of the line-profiler 4.1.1 release) |
We might have some updates from atef on these widgets. Perhaps we merge and then follow up? |
It does look like there have been some changes. I'm happi to merge those changes in later. This addition does make me wonder if it's worth the time to figure out how to separate happi[ui] from happi[core]. There's not too much to this GUI currently, but I kinda liked the pure-code-ness of happi. also if I have to add qt tests to happi I'm gonna cry |
I suppose we could have |
I do think having the viewer in this package will be helpful. Maybe we reconsider |
Should we merge this before or after the upcoming tag? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with merging this, with the understanding that we'll have to merge in the updated version from atef and/or create happi-qt later on.
closes #221 |
Description
Add more user-friendly happi search widget from atef.
Motivation and Context
We made these for atef, we may as well upstream them to happi.
We need to find a home for the ophyd device tool as well - likely not happi.
How Has This Been Tested?
Where Has This Been Documented?
Screenshots (if appropriate):