Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: add happi search widget from atef #246

Merged
merged 3 commits into from
Nov 7, 2023

Conversation

klauer
Copy link
Contributor

@klauer klauer commented May 12, 2022

Description

Add more user-friendly happi search widget from atef.

Motivation and Context

We made these for atef, we may as well upstream them to happi.
We need to find a home for the ophyd device tool as well - likely not happi.

How Has This Been Tested?

Where Has This Been Documented?

Screenshots (if appropriate):

image

image

@klauer klauer force-pushed the enh_search_widgets branch from 7c2f427 to 1be67f6 Compare August 22, 2023 14:27
@klauer
Copy link
Contributor Author

klauer commented Aug 22, 2023

(Rebasing on happi master; less because I want to work on this PR and more because I want to see the effect of the line-profiler 4.1.1 release)

@klauer klauer marked this pull request as ready for review September 21, 2023 23:01
@klauer
Copy link
Contributor Author

klauer commented Sep 21, 2023

We might have some updates from atef on these widgets. Perhaps we merge and then follow up?

@klauer klauer requested review from ZLLentz and tangkong September 21, 2023 23:02
@tangkong
Copy link
Contributor

It does look like there have been some changes. I'm happi to merge those changes in later.

This addition does make me wonder if it's worth the time to figure out how to separate happi[ui] from happi[core]. There's not too much to this GUI currently, but I kinda liked the pure-code-ness of happi.

also if I have to add qt tests to happi I'm gonna cry

@klauer
Copy link
Contributor Author

klauer commented Sep 21, 2023

I suppose we could have happi-qt instead? I'm fine with that I guess, but having it get out of sync would be a bit painful

@tangkong
Copy link
Contributor

I do think having the viewer in this package will be helpful. Maybe we reconsider happi-qt or happi[qt] when we accrue more substantial ui elements. For now I'm ok with this

@klauer klauer changed the title WIP/ENH: add happi search widget from atef ENH: add happi search widget from atef Sep 21, 2023
@ZLLentz
Copy link
Member

ZLLentz commented Sep 27, 2023

Should we merge this before or after the upcoming tag?

@klauer
Copy link
Contributor Author

klauer commented Nov 7, 2023

This may be ready to merge? @ZLLentz @tangkong

Copy link
Contributor

@tangkong tangkong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with merging this, with the understanding that we'll have to merge in the updated version from atef and/or create happi-qt later on.

@tangkong
Copy link
Contributor

tangkong commented Nov 7, 2023

closes #221

@klauer klauer linked an issue Nov 7, 2023 that may be closed by this pull request
@klauer klauer merged commit 582b72c into pcdshub:master Nov 7, 2023
9 checks passed
@klauer klauer deleted the enh_search_widgets branch November 7, 2023 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Happi GUI Front-end tools (Qt and/or web-based)
3 participants