Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT: improve happi audit output #339

Merged
merged 4 commits into from
Nov 13, 2023
Merged

MNT: improve happi audit output #339

merged 4 commits into from
Nov 13, 2023

Conversation

tangkong
Copy link
Contributor

@tangkong tangkong commented Nov 7, 2023 •
edited
Loading

Description

  • gives non-interactive audit tables a max width
  • fixes bad logic in table construction

Motivation and Context

I want audits to be more useful
closes #338

How Has This Been Tested?

interactively

Where Has This Been Documented?

This PR

Pre-merge checklist

  • Code works interactively
  • Code contains descriptive docstrings, including context and API
  • New/changed functions and methods are covered in the test suite where possible
  • Test suite passes locally
  • Test suite passes on GitHub Actions
  • Ran docs/pre-release-notes.sh and created a pre-release documentation page
  • Pre-release docs include context, functional descriptions, and contributors as appropriate

@tangkong tangkong marked this pull request as ready for review November 11, 2023 00:32
@tangkong tangkong requested a review from ZLLentz November 11, 2023 00:32
ZLLentz
ZLLentz approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@ZLLentz ZLLentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes make sense and look good to me

@ZLLentz ZLLentz merged commit 63051ea into pcdshub:master Nov 13, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZLLentz ZLLentz ZLLentz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ENH: help happi audit pipe / redirect / write to a file
2 participants
@tangkong @ZLLentz