Refactor RDF/XML parser error #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the newer version of quick-xml the `failure` crate is removed and `quick_xml::Error` now implements `std::error::Error`.
Replace everything `error-chain` related in the XML-parser. In addition xml.rs was refactored into smaller mods (the original file over 1800 lines). Furthermore, the parser-error variants of `error::Error` where removed.
Introduced `LocatableError` to add locations to an error with custom sources of location. Based on that `LocateResult` is introduced. An extension trait for `Result`s that basically performs `map_err`.
MattesWhite
commented
Jan 14, 2020
| Ok(name) => Err(RdfError::UnexpectedEvent { | ||
| expected: format!("<{}>", name), | ||
| found: "text".to_owned(), | ||
| }) |
There was a problem hiding this comment.
@althonos I refactored the lines above for the new error-handling in sophia.
I'm not sure if expected and found are switched or if it is correct this way. Could you tell me, please?
Same case l.613
|
What about merging this PR? As @althonos already 'thumb uped' this PR I guess he agrees to this. |
|
Sorry, the thumbs up didn't generate any notification, so I hadn't noticed it :) Good for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue the work for #8 .
Refactors the error-handling in
parser::xml.error-chainis removedthiserror-based error type is introducedWithLocationis supportedxml.rsis split into smaller modulesNote: The version of
quick_xmlwas updated. In the newer version they removed the dependency onfailureand implementedstd::error::Errorfor their error type.