reasons for xfails

pcluo · Apr 19, 2017 · ceb9171 · ceb9171
1 parent e2cfa77
commit ceb9171
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 9 deletions.
diff --git a/pandas/tests/formats/test_css.py b/pandas/tests/formats/test_css.py
@@ -28,7 +28,7 @@ def test_css_parse_normalisation(name, norm, abnorm):
     assert_same_resolution(norm, abnorm)
 
 
-@pytest.mark.xfail
+@pytest.mark.xfail(reason='CSS comments not yet stripped')
 def test_css_parse_comments():
     assert_same_resolution('hello: world',
                            'hello/* foo */:/* bar \n */ world /*;not:here*/')
@@ -41,7 +41,8 @@ def test_css_parse_specificity():
     pass  # TODO
 
 
-@pytest.mark.xfail
+@pytest.mark.xfail(reason='Splitting CSS declarations not yet sensitive to '
+                          '; in CSS strings')
 def test_css_parse_strings():
     # semicolons in strings
     assert_resolves('background-image: url(\'http://blah.com/foo?a;b=c\')',
@@ -91,7 +92,7 @@ def test_css_side_shorthands(shorthand, expansions):
                         {})
 
 
-@pytest.mark.xfail
+@pytest.mark.xfail(reason='CSS font shorthand not yet handled')
 @pytest.mark.parametrize('css,props', [
     ('font: italic bold 12pt helvetica,sans-serif',
      {'font-family': 'helvetica,sans-serif',
@@ -108,7 +109,7 @@ def test_css_font_shorthand(css, props):
     assert_resolves(css, props)
 
 
-@pytest.mark.xfail
+@pytest.mark.xfail(reason='CSS background shorthand not yet handled')
 @pytest.mark.parametrize('css,props', [
     ('background: blue', {'background-color': 'blue'}),
     ('background: fixed blue',
@@ -118,7 +119,7 @@ def test_css_background_shorthand(css, props):
     assert_resolves(css, props)
 
 
-@pytest.mark.xfail
+@pytest.mark.xfail(reason='CSS border shorthand not yet handled')
 @pytest.mark.parametrize('style,equiv', [
     ('border: 1px solid red',
      'border-width: 1px; border-style: solid; border-color: red'),

diff --git a/pandas/tests/formats/test_to_excel.py b/pandas/tests/formats/test_to_excel.py
@@ -73,11 +73,14 @@
     ('text-shadow: 0px -0em 2px #CCC', {'font': {'shadow': True}}),
     ('text-shadow: 0px -0em 2px', {'font': {'shadow': True}}),
     ('text-shadow: 0px -2em', {'font': {'shadow': True}}),
-    # text-shadow with color first not yet implemented
     pytest.mark.xfail(('text-shadow: #CCC 3px 3px 3px',
-                       {'font': {'shadow': True}})),
+                       {'font': {'shadow': True}}),
+                      reason='text-shadow with color preceding width not yet '
+                             'identified as shadow'),
     pytest.mark.xfail(('text-shadow: #999 0px 0px 0px',
-                       {'font': {'shadow': False}})),
+                       {'font': {'shadow': False}}),
+                      reason='text-shadow with color preceding zero width not '
+                             'yet identified as non-shadow'),
     # FILL
     # - color, fillType
     ('background-color: red', {'fill': {'fgColor': 'FF0000',
@@ -209,6 +212,7 @@ def test_css_to_excel_inherited(css, inherited, expected):
     assert expected == convert(css)
 
 
-@pytest.mark.xfail
+@pytest.mark.xfail(reason='We are not currently warning for all unconverted '
+                          'CSS, but possibly should')
 def test_css_to_excel_warns_when_not_supported():
     pass  # TODO