Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SDK config support #6

Merged
merged 1 commit into from
Mar 16, 2022
Merged

Add SDK config support #6

merged 1 commit into from
Mar 16, 2022

Conversation

boozook
Copy link
Member

@boozook boozook commented Mar 16, 2022

Need for cases where SDK is in custom place installed.

@boozook
Copy link
Member Author

boozook commented Mar 16, 2022

That's not complete impl and for macOS only. On *nix we have to read PLAYDATE_SDK_PATH env.
But it works for custom sdk Installation paths.

@rtsuk
Copy link
Collaborator

rtsuk commented Mar 16, 2022

Is this reading a file the Playdate SDK installer writes?

@boozook
Copy link
Member Author

boozook commented Mar 16, 2022

Exactly. That's config with path of SDK.

@rtsuk
Copy link
Collaborator

rtsuk commented Mar 16, 2022

You feel it's benign on Windows and Linux?

@boozook
Copy link
Member Author

boozook commented Mar 16, 2022

I donk know actually, but

  • there's if config not found just use default sdk path (your implementation)
  • I'm sure we can test it on CI ;)

@rtsuk
Copy link
Collaborator

rtsuk commented Mar 16, 2022

I'm sure the Windows users will let us know if this breaks them.

Joking aside, CI would be great, but I have no idea if it is possible or how to go about setting it up.

@rtsuk rtsuk merged commit e8635c6 into pd-rs:main Mar 16, 2022
@boozook boozook deleted the cfg-support branch March 16, 2022 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants