Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve platform dependent cstr point types for menu API #83

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

tehsmeely
Copy link
Contributor

@tehsmeely tehsmeely commented Jan 20, 2024

Resolves the types being used to represent cstring pointers in the menu API
being platform dependent.

Speficially I originally wrote it using i8 but it turns out other platforms use u8.
See the docs for more

The type of the returned pointer is *const c_char, and whether it’s an alias for *const i8 or *const u8 is platform-specific.

So we never force this into one of the two, and just use the ffi::c_char type as returned by CString::as_ptr

This refers to
#79
and
#82

@boozook boozook linked an issue Jan 22, 2024 that may be closed by this pull request
@boozook boozook merged commit 362f656 into pd-rs:main Jan 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Access to system menu API
2 participants