core: Add SampleBuffer::samples_mut
#147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows mutable access to exported samples, enabling in-place processing of output audio data. Currently, to use functions like libopus's soft_clip (which take `&mut [f32]`, interleaved) this can only be achieved on `SampleBuffer` with a significant memcopy (seemingly ~80us for 1920 `f32` samples, relative to ~40us decode). `samples_mut` removes this additional overhead.
|
Thanks @FelixMcFelix, this change makes a lot of sense to me. Apologies for the delay in getting this merged, got a bit too busy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows mutable access to exported samples, enabling in-place processing of output audio data.
Currently, to use functions like libopus's soft_clip (which take
&mut [f32], interleaved) this can only be achieved onSampleBufferwith a significant memcopy (seemingly ~8us for 1920f32samples, relative to ~40us decode + ~80us encode).samples_mutremoves this additional overhead.