Skip to content

Commit

Permalink
docs(argo-cd): Update docs with the correct default for application.i…
Browse files Browse the repository at this point in the history
…nstanceLabelKey (argoproj#2447)

docs: Update docs with the correct default for application.instanceLabelKey

Signed-off-by: Matt Dainty <matt@bodgit-n-scarper.com>
  • Loading branch information
bodgit authored Jan 23, 2024
1 parent c734875 commit 9e70f24
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 4 deletions.
4 changes: 2 additions & 2 deletions charts/argo-cd/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ appVersion: v2.9.5
kubeVersion: ">=1.23.0-0"
description: A Helm chart for Argo CD, a declarative, GitOps continuous delivery tool for Kubernetes.
name: argo-cd
version: 5.53.7
version: 5.53.8
home: https://github.com/argoproj/argo-helm
icon: https://argo-cd.readthedocs.io/en/stable/assets/logo.png
sources:
Expand All @@ -27,4 +27,4 @@ annotations:
url: https://argoproj.github.io/argo-helm/pgp_keys.asc
artifacthub.io/changes: |
- kind: changed
description: Change redis repository to public.ecr.aws
description: Updated documented default value for application.instanceLabelKey.
2 changes: 1 addition & 1 deletion charts/argo-cd/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -450,7 +450,7 @@ NAME: my-release
|-----|------|---------|-------------|
| configs.clusterCredentials | list | `[]` (See [values.yaml]) | Provide one or multiple [external cluster credentials] |
| configs.cm."admin.enabled" | bool | `true` | Enable local admin user |
| configs.cm."application.instanceLabelKey" | string | Defaults to app.kubernetes.io/instance | The name of tracking label used by Argo CD for resource pruning |
| configs.cm."application.instanceLabelKey" | string | `"argocd.argoproj.io/instance"` | The name of tracking label used by Argo CD for resource pruning |
| configs.cm."exec.enabled" | bool | `false` | Enable exec feature in Argo UI |
| configs.cm."server.rbac.log.enforce.enable" | bool | `false` | Enable logs RBAC enforcement |
| configs.cm."timeout.hard.reconciliation" | string | `"0s"` | Timeout to refresh application data as well as target manifests cache |
Expand Down
1 change: 0 additions & 1 deletion charts/argo-cd/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,6 @@ configs:
url: ""

# -- The name of tracking label used by Argo CD for resource pruning
# @default -- Defaults to app.kubernetes.io/instance
application.instanceLabelKey: argocd.argoproj.io/instance

# -- Enable logs RBAC enforcement
Expand Down

0 comments on commit 9e70f24

Please sign in to comment.