chore: Bump serde_json from 1.0.105 to 1.0.106 (#193) #528
clippy
4 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 4 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.72.0 (5680fa18f 2023-08-23)
- cargo 1.72.0 (103a7ff2e 2023-08-15)
- clippy 0.1.72 (5680fa1 2023-08-23)
Annotations
Check warning on line 99 in fatigue/src/main.rs
github-actions / clippy
deref which would be done by auto-deref
warning: deref which would be done by auto-deref
--> fatigue/src/main.rs:99:47
|
99 | output_formatter.update_result_status(&*rx.borrow());
| ^^^^^^^^^^^^^ help: try this: `&rx.borrow()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
= note: `#[warn(clippy::explicit_auto_deref)]` on by default
Check warning on line 77 in fatigue/src/main.rs
github-actions / clippy
usage of an `Arc` that is not `Send` or `Sync`
warning: usage of an `Arc` that is not `Send` or `Sync`
--> fatigue/src/main.rs:77:28
|
77 | let output_formatter = Arc::new(get_output_formatter());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: the trait `Send` is not implemented for `Box<dyn OutputFormatter>`
= note: the trait `Sync` is not implemented for `Box<dyn OutputFormatter>`
= note: required for `Arc<Box<dyn OutputFormatter>>` to implement `Send` and `Sync`
= help: consider using an `Rc` instead or wrapping the inner type with a `Mutex`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync
= note: `#[warn(clippy::arc_with_non_send_sync)]` on by default
Check warning on line 43 in libfatigue/src/context/actions/json.rs
github-actions / clippy
returning the result of a `let` binding from a block
warning: returning the result of a `let` binding from a block
--> libfatigue/src/context/actions/json.rs:43:21
|
42 | let res = serde_json::from_str(raw.as_str())?;
| ---------------------------------------------- unnecessary `let` binding
43 | res
| ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
= note: `#[warn(clippy::let_and_return)]` on by default
help: return the expression directly
|
42 ~
43 ~ serde_json::from_str(raw.as_str())?
|
Check warning on line 36 in libfatigue/src/actions/request.rs
github-actions / clippy
useless conversion to the same type: `std::str::Lines<'_>`
warning: useless conversion to the same type: `std::str::Lines<'_>`
--> libfatigue/src/actions/request.rs:34:43
|
34 | let rendered_path_lines: Vec<_> = rendered_path
| ___________________________________________^
35 | | .lines()
36 | | .into_iter()
| |________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `#[warn(clippy::useless_conversion)]` on by default
help: consider removing `.into_iter()`
|
34 ~ let rendered_path_lines: Vec<_> = rendered_path
35 + .lines()
|