-
-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
About limitation of GITHUB_TOKEN #9
Comments
Does this cause the |
No, your case seems to be new. Please create a new issue and tell me more details. |
I ran into the same issue. The manual way to fix it is from settings, flip your branch to A better way to fix it is to create a personal access token and use that in secrets instead. |
Thanks @thefringeninja I will release
Ok. |
|
@peaceiris : Do you know if there is a support ticket for this problem ? |
This problem is a known issue. I have faced the same issue on GitHub Actions v1 and some people have reported this to GitHub support. As we see at the JamesIves/github-pages-deploy-action#5, GitHub should already know this. If this issue is not fixed for a long time, we probably |
I found the post on the GitHub Community Forum. Github action not triggering gh-pages upon push - GitHub Community Forum Community Manager said:
|
Yes, it seems like that's not a bug but a normal behavior in the context of the security rule imposed in Github Actions which is "A workflow can not trigger another workflow". I posted an answer to ask if they could re-consider this limitation in this precise use case due to the obvious usability issue it creates. I propose that we wait their answer and if it's negative we could just close this issue as "not a bug" and adapt the documentation of this project to explain it will never be possible to use |
Thank you @nicolas-van
I got it clearly. I will update the README following your suggestion. |
Hmmm, according to the most recent answer of this thread it might not be by design in the end. I'm gonna test what is proposed to see if it works when I have some time. |
Yes, I am also following that thread.
This action already supports the above and I tested at peaceiris/hugo-test-project. I could push to |
Trigger hugo's deployment process and commit to the gh-pages branch upon merging to master.
GitHub might have started to supporting to trigger the GitHub Pages build event by GITHUB_TOKEN on public repositories. (We can already use the token on private repositories.) Be careful, there is no official announcement about this by GitHub. cf. #9
GitHub might have started to supporting to trigger the GitHub Pages build event by GITHUB_TOKEN on public repositories. (We can already use the token on private repositories.) Be careful, there is no official announcement about this by GitHub. cf. #9
GitHub might have started to supporting to trigger the GitHub Pages build event by GITHUB_TOKEN on public repositories. (We can already use the token on private repositories.) Be careful, there is no official announcement about this by GitHub. cf. #9
Unfortunately, the build with |
Didn't had a problem personally. The only strange behavior I encountered was that, when I created this repository (which is a reusable boilerplate for Parcel I was hoping to create for a long time by the way), I had to kind of "confirm" to Github in the settings of the repository that I really wanted to deploy that web site from the Then I made 40+ commits that all triggered a publish without problem. |
@nicolas-van Thank you for telling me your log and the boilerplate looks very useful. In my case, when I push two commits with shorter intervals, the first one fails. |
From another point of view, that behavior also sounds good. When the second event starts in the middle of the first one, the first one may be canceled. It is my expectation. |
See #104 (comment)
|
I addition to the quote above. I've also experienced inconsistent triggering of GitHub Pages build at https://github.com/dhimmel/rootstock-branchless-setup/commits/gh-pages: See how the first commit did not trigger a build. In Settings, I switched GitHub Pages to build master and then switched back to gh-pages and that seemed to resolve the issue. Note that the master branch build for the commit that did not trigger Pages has previously failed. In both cases, the failed deployment followed a master commit whose workflow previously failed and now passed. Not sure if this has any relevance. |
Yeah, I think this is the case for me too. Initially upon going to the settings after there is a GITHUB_TOKEN created commit on And then after re-selecting "gh-pages" branch for source: Subsequently, I make a dummy commit like |
Yeah, I had exactly the same behavior in the Settings page. Another problem I had additionally was that adding a empty commit after fixing the settings didn't seemed sufficient. It triggered the Gihub Actions workflow but not the Github Pages workflow. It seemed necessary to really alter the content of the I think Github has some mechanism to avoid publishing if the content of By the way, this is completely unrelated but it could be a good idea to add that |
GitHub might have started to supporting to trigger the GitHub Pages build event by GITHUB_TOKEN on public repositories. (We can already use the token on private repositories.) Be careful, there is no official announcement about this by GitHub. cf. #9
GitHub might have started to supporting to trigger the GitHub Pages build event by GITHUB_TOKEN on public repositories. (We can already use the token on private repositories.) Be careful, there is no official announcement about this by GitHub. cf. #9
If using an empty commit with this action, you would have to set |
I've read this thread three times, but couldn't quite understand - does deployment work with My experients show that it does work. |
@slonopotamus Yes, the deployment with |
Finally, I put the If the deployment with Thanks! |
Use https://github.com/peaceiris/actions-gh-pages to publish to the gh-pages branch. This will hopefully remove some config and tokens that we need to save now that GH Actions support pushing branch via the GITHUB_TOKEN secret See: peaceiris/actions-gh-pages#9
Use https://github.com/peaceiris/actions-gh-pages to publish to the gh-pages branch. This will hopefully remove some config and tokens that we need to save now that GH Actions support pushing branch via the GITHUB_TOKEN secret See: peaceiris/actions-gh-pages#9
GitHub Actions v2 is still beta and deploying to GitHub Pages with
GITHUB_TOKEN
has some problems. Until it is fixed, I provideACTIONS_DEPLOY_KEY
to deploy with ssh frompeaceiris/actions-gh-pages@v2.0.0
The text was updated successfully, but these errors were encountered: