Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Split installer into some functions #33

Merged
merged 16 commits into from
Jan 5, 2020
Merged

refactor: Split installer into some functions #33

merged 16 commits into from
Jan 5, 2020

Conversation

peaceiris
Copy link
Owner

@peaceiris peaceiris commented Jan 3, 2020 •
edited
Loading

@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2020

Pull Request Test Coverage Report for Build e91ed9d1e08f8af6ec03dabcac906835dbd18046-PR-33

  • 9 of 10 (90.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 85.034%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/installer.ts 9 10 90.0%
Totals Coverage Status
Change from base Build 30be24c97d7ebd2dbd62640b65f65c1186dbea1f: 0.3%
Covered Lines: 103
Relevant Lines: 113
💛 - Coveralls

@peaceiris peaceiris changed the title refactor: Add createTempDir() refactor: Split some functions Jan 3, 2020
@peaceiris peaceiris changed the title refactor: Split some functions refactor: Split installer into some functions Jan 3, 2020
@peaceiris peaceiris merged commit dd67832 into master Jan 5, 2020
@peaceiris peaceiris deleted the refactor-installer branch January 5, 2020 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@peaceiris