fix issue #947 #948
Open
fix issue #947 #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moisedk
suggested changes
Dec 20, 2024
|
[like] Sotaire Kwizera reacted to your message:
…________________________________
From: Moise Dete-Kpinssounon ***@***.***>
Sent: Friday, December 20, 2024 8:32:12 PM
To: pearcej/cppds ***@***.***>
Cc: Sotaire Kwizera ***@***.***>; Author ***@***.***>
Subject: Re: [pearcej/cppds] fix issue #947 (PR #948)
[EXTERNAL SENDER]
@moisedk requested changes on this pull request.
Could you please remove the explicit correct='no' to keep things consistent?
Also, in your future PRs, you can check 'Allow edits from maintainers' so I can make small edits when necessary before merging the PR.
Thank you.
—
Reply to this email directly, view it on GitHub<#948 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A5GTACBXOCE5ZFNBS5XYALL2GR5EZAVCNFSM6AAAAABT7PJQS2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMJYGMYDGOJRGY>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I adjusted the
<choice> </choice>tag from<choice correct="true">to<choice correct="yes">Related Issue
I saw that there are a few other chapters with similar issue. I am gonna report them and fix them next week.
How Has This Been Tested?
I made necessary changes and rebuilt the book on the local host.