Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Rule to docs #170

Merged
merged 2 commits into from
Jun 18, 2021
Merged

Expose Rule to docs #170

merged 2 commits into from
Jun 18, 2021

Conversation

yordis
Copy link
Contributor

@yordis yordis commented May 10, 2021

Cocktail.Rule.t() is being used in multiple places, therefore we need to expose Cocktail.Rule in order to see the documentation of the type.

Screen Shot 2021-05-09 at 8 11 41 PM

Copy link
Collaborator

@doughsay doughsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@codecov
Copy link

codecov bot commented May 11, 2021

Codecov Report

Merging #170 (8c98015) into main (2b12aa0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #170   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines          369       369           
=========================================
  Hits           369       369           
Impacted Files Coverage Δ
lib/cocktail/rule.ex 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b12aa0...8c98015. Read the comment docs.

@yordis
Copy link
Contributor Author

yordis commented May 23, 2021

@doughsay same here, any opportunity to merge and release this?

@doughsay doughsay merged commit bad21b5 into peek-travel:main Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants