Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build_rule to builder #174

Merged
merged 3 commits into from
Jun 18, 2021
Merged

Add build_rule to builder #174

merged 3 commits into from
Jun 18, 2021

Conversation

yordis
Copy link
Contributor

@yordis yordis commented May 10, 2021

fixes #172

Copy link
Collaborator

@doughsay doughsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@codecov
Copy link

codecov bot commented May 11, 2021

Codecov Report

Merging #174 (1b407e0) into main (bad21b5) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #174   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines          369       371    +2     
=========================================
+ Hits           369       371    +2     
Impacted Files Coverage Δ
lib/cocktail/builder/i_calendar.ex 100.00% <100.00%> (ø)
lib/cocktail/schedule.ex 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bad21b5...1b407e0. Read the comment docs.

@yordis
Copy link
Contributor Author

yordis commented May 12, 2021

Sorry, I forgot to add the test case .... my bad

@yordis
Copy link
Contributor Author

yordis commented May 23, 2021

@doughsay any opportunity to merge and release this?

@doughsay doughsay merged commit 8967132 into peek-travel:main Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Be able to get the string representation of rrule only
2 participants