Fix a couple typespecs in Cocktail.Span #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #66 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 19 19
Lines 323 323
=====================================
Hits 323 323
Continue to review full report at Codecov.
|
doughsay
requested changes
Nov 8, 2018
mix.exs
Outdated
| @@ -63,7 +63,7 @@ defmodule Cocktail.Mixfile do | |||
| defp deps do | |||
| [ | |||
| {:credo, "~> 0.8", only: [:dev, :test], runtime: false}, | |||
| {:dialyxir, "~> 0.5", only: [:dev, :test], runtime: false}, | |||
| {:dialyxir, "~> 1.0.0-rc.4", only: [:dev, :test], runtime: false}, | |||
There was a problem hiding this comment.
This would require us to release an rc rather than a regular release. Downgrade this to latest stable if you want me to make a new non-rc release.
There was a problem hiding this comment.
I've pushed a set of changes that no longer include bumping the version of dialyxir.
dhedlund
force-pushed
the
bump-dialyxir
branch
from
10035d2
to
3d2f28b
Compare
dhedlund
changed the title
doughsay
approved these changes
Nov 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump the version of dialyxir so it supportsfix a couple typespecs that were overly strict .--format dialyxir, andOnly the first argument of
Cocktail.Span.compare/2andCocktail.Span.overlap_mode/2had been relaxed to accept any map that defined a:fromand:untilproperty. This PR relaxes the type of both arguments.One of the return values from
Cocktail.Span.overlap_mode/2was not being included in the typespec for that function.