Skip to content

Commit

Permalink
Issue #270 Don't swap the 8080 port in a patch release (#271)
Browse files Browse the repository at this point in the history
* Issue #270 Don't swap the 8080 port in a patch release

* Update travis build to use bionic and latest npm
  • Loading branch information
pega-talba authored Apr 2, 2021
1 parent bfd5259 commit 74d82dc
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
3 changes: 2 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
language: python
os: linux
dist: xenial
dist: bionic
env:
global:
- HELM_URL=https://get.helm.sh
Expand All @@ -14,6 +14,7 @@ install:
- PATH=`pwd`/linux-amd64/:$PATH
# Install YamlLint
- sudo pip install yamllint=="${YAMLLINT_VERSION}"
- nvm install --lts
- npm install -g --save remark-cli to-vfile remark-preset-lint-recommended remark-validate-links remark-lint-no-dead-urls remark-message-control remark-preset-lint-markdown-style-guide remark-lint
# Install Go
- eval "$(gimme 1.13.1)"
Expand Down
4 changes: 2 additions & 2 deletions charts/pega/templates/_pega-deployment.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ spec:
livenessProbe:
httpGet:
path: "/{{ template "pega.applicationContextPath" . }}/PRRestService/monitor/pingService/ping"
port: 8081
port: 8080
scheme: HTTP
initialDelaySeconds: {{ $livenessProbe.initialDelaySeconds | default 0 }}
timeoutSeconds: {{ $livenessProbe.timeoutSeconds | default 20 }}
Expand Down Expand Up @@ -225,7 +225,7 @@ spec:
livenessProbe:
httpGet:
path: "/{{ template "pega.applicationContextPath" . }}/PRRestService/monitor/pingService/ping"
port: 8081
port: 8080
scheme: HTTP
initialDelaySeconds: {{ $livenessProbe.initialDelaySeconds | default 200 }}
timeoutSeconds: {{ $livenessProbe.timeoutSeconds | default 20 }}
Expand Down
2 changes: 1 addition & 1 deletion terratest/src/test/pega/pega-tier-deployment_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ func VerifyDeployment(t *testing.T, pod *k8score.PodSpec, expectedSpec pegaDeplo
require.Equal(t, int32(1), pod.Containers[0].LivenessProbe.SuccessThreshold)
require.Equal(t, int32(3), pod.Containers[0].LivenessProbe.FailureThreshold)
require.Equal(t, "/prweb/PRRestService/monitor/pingService/ping", pod.Containers[0].LivenessProbe.HTTPGet.Path)
require.Equal(t, intstr.FromInt(8081), pod.Containers[0].LivenessProbe.HTTPGet.Port)
require.Equal(t, intstr.FromInt(8080), pod.Containers[0].LivenessProbe.HTTPGet.Port)
require.Equal(t, k8score.URIScheme("HTTP"), pod.Containers[0].LivenessProbe.HTTPGet.Scheme)

require.Equal(t, int32(30), pod.Containers[0].ReadinessProbe.InitialDelaySeconds)
Expand Down

0 comments on commit 74d82dc

Please sign in to comment.