US-389994 Initial helm charts SRS backing service #211
Conversation
pega-kshev
requested review from
dcasavant,
taz-pega-work and
a team
as code owners
|
Hi @dcasavant the PR is ready for review, kindly also include other reviewers aswell. Thank you. |
charts/backingservices/charts/srs/templates/srsservice_networkpolicy.yaml
Show resolved
Hide resolved
|
@taz-mon this will need to be added to the runbooks for 8.6 |
pega-kshev
requested review from
Max-Levitskiy,
misterdorito,
pega-roska and
zitikay
charts/backingservices/charts/srs/templates/srsservice_deployment.yaml
Outdated
Show resolved
Hide resolved
|
@pega-kshev Travis run seems to be failing because of yamllint issue. Can you please look into it. |
|
@MadhuriArugula thanks for pointing out, I have corrected it now. |
There was a problem hiding this comment.
@pega-kshev a general comment, here backingservices is considered as a chart and srs as subchart, backingservices itself does not have any templates associated. Do we have a usecase to perceive backingservices as a chart. Instead can this be a just folder, srs is the main chart in it. (likewise any other backing services in future). As you are aware, helm subcharts technique does not handle dependencies well.
@dcasavant What are your views on this comment?
@kishorv10 I dont have immediate insight into what implications that could have, if we define backingservices as a chart but by defining backing services as a chart and services as subcharts, please correct me if I am wrong, one usecase I could see is to have a single values.yaml to configure multiple backing services, secondly, we have flexibility to implement supporting services under backingservices umbrella which would provide common functionality like a service mesh such as this proposal, which would help inject proxy containers using istio or linkerd into other backing service pods.
|
|
Adding helm charts for Search and Reporting backing service.
TODO: add test files and README.md content for backingservices chart.