make installer PDB a hook to avoid conflicts with upgrade jobs #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
APegaDavis
force-pushed
the
make_installer_pdb_hook
branch
from
046a9f7 to
80fda7f
Compare
zitikay
reviewed
Apr 9, 2024
There was a problem hiding this comment.
I was initially thinking we'd want pre-install/pre-upgrade hooks, to ensure we delete then create to avoid conflicts, but now actually leaning back towards post-* hooks because that just means once job is done we clean up PDB, and since job is done PDB isn't really needed anymore
khick77
approved these changes
Apr 9, 2024
MadhuriArugula
approved these changes
Apr 10, 2024
Heshma
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some scenarios install charts may be deployed twice, once for install and once for upgrade. This leads to a conflict on the installer PDB which is used for both.
This PR makes the PDB a hook to avoid that conflict.