Added pod affinity support #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntation accordingly
…n top part of _supplemental.tpl files
…max22/pega-helm-charts into feature/pod-affinity-support
|
@Anand-Kotamsetti @nikhilparmar86 Can you please review the changes from respective sub charts? |
bhowd1
reviewed
Jul 8, 2024
There was a problem hiding this comment.
From SRS helm chart POV, changes looks good to me!!
Before approving it wanted to know that, did we test these changes by deploying it locally also can we add tests for the same in terratest/src/test/backingservices/srs-deployment_test.go ?
Thanks
|
@alemax22 Can you add corresponding tests for all the referenced deployments in this PR ? Also would you be able to resolve the conflicts? |
* remove obsolete logger * update expected contents
…#757) * support configuration of ndots * quote ndots to avoid json unmarshall error --------- Co-authored-by: Bachir Berrachedi <bachir.berrachedi@pega.com> Co-authored-by: Adam Talbot <Adam.Talbot@pega.com>
* BUG-868785 Update values.yaml with replication factor 3 Pega recommended replication factor is 3 --------- Co-authored-by: MadhuriArugula <madhuriarugula77@gmail.com>
…R's with no activity (pegasystems#756) * US-614190: Stale action workflow to handle for github repo issues & pull requests with no activity for more than 60 days * fixed review comments * fixed review comments --------- Co-authored-by: rajuu <UmaveeraBasaveswararao.Rajulapati@pega.com>
* removing conditional statements for LRW * Keeping indenting consistent --------- Co-authored-by: locoe <Evan.Loconto@pega.com>
Co-authored-by: MadhuriArugula <madhuriarugula77@gmail.com>
Co-authored-by: vermn1 <nihal.verma@in.pega.com>
* [US-624017] Adding JDBC Connection information * Edited wording following SME suggestion
|
@MadhuriArugula unit tests created for every deployment modified and updated branch with the last changes from the master |
bhowd1
approved these changes
Jul 9, 2024
MadhuriArugula
approved these changes
Jul 9, 2024
|
@npjohnson637 Can you review the PR for constellation chart. |
nikhilparmar86
approved these changes
Jul 9, 2024
arvasrikanth
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added pod affinity support in:
Updated the documentations of all the above charts in order to describe how to adopt the pod affinity feature in the charts.
Resolves Missing nodeSelector for search and hazelcast/clustering service pods #580