-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
US-512975 Support custom backendConfig for GKE #747
US-512975 Support custom backendConfig for GKE #747
Conversation
Merge with master
Merge with master
docs/Deploying-Pega-on-GKE.md
Outdated
@@ -523,6 +523,18 @@ tier: | |||
# e.g. web.mypega.example.com | |||
domain: "**gke.web.dev.pega.io**" | |||
``` | |||
18. To apply additional configuration for GKE Load balancer, configure BackendConfig with a referenced service port and associate necessary parameters as per need. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably describe the overridable elements like drainingTimeoutSec
or timeOutSec
that are asked in the issue instead of referenced service port and associate necessary parameters as per need.
Also, can you link the backendConfig spec for easy reference?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kishorv10 Updated documentation.
@kingakowalska1 Can you review the documentation changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
Here are my comments/suggested changes for the readmes:
charts/pega/README.md (lines 374 and 376)
Depending on what type of deployment you use, if there are any long-running operations such as import, append provider-specific ingress timeout annotation under each tier.
The following example shows timeout annotation overrides for an Openshift deployment:
docs/Deploying-Pega-on-GKE.md
line 526
To apply additional configuration for GKE Load balancer, configure backendConfig
with a custom timeout or a connectionDraining
timeout as shown in the following example. For more information on additional parameters in backendConfig
, see Google documentation.
Line 536
Note: Parameters provided in the backendConfig
section of values.yaml override the parameters section of the existing template if it is already configured.
Thanks!
Kinga
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
BackendConfig is custom resource definitions (CRDs) that allow you to further customise the load balancer and this is specific to GKE provider.
Pega Helm charts has default configurations for BackendConfig CRD, however the parameters can be customisable as per the user requirements. This PR would be opening the parameters in backendConfig resource.
If there are configurations provided in values.yaml, we fallback to the defaults present in pega-helm-charts templates.