-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added configurability of hazelcast/clusteringservice name #814
Open
alemax22
wants to merge
19
commits into
pegasystems:master
Choose a base branch
from
alemax22:feature/clustering-service-name
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Added configurability of hazelcast/clusteringservice name #814
alemax22
wants to merge
19
commits into
pegasystems:master
from
alemax22:feature/clustering-service-name
+213
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alemax22
requested review from
a team,
taz-pega-work and
kingakowalska1
as code owners
September 29, 2024 23:20
@vnihal72 :- Could your team review this PR? |
alemax22
changed the title
Added cofigurability of hazelcast/clusteringservice name
Added configurability of hazelcast/clusteringservice name
Nov 1, 2024
Fixed reference to values.yaml file into the README.md file of the addons |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabled configuration of the hazelcast/clusteringservice deployment name by means of the chart.
This allows the users to adhere to company naming conventions on the k8s deployments.
The PR contains also all the UT to test the new feature and it updates the current documentation.
The PR fixes #813.