Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

US-622676 - helm chart changes for tcp keep alive probe #837

Merged
merged 9 commits into from
Oct 22, 2024
Merged

US-622676 - helm chart changes for tcp keep alive probe #837

merged 9 commits into from
Oct 22, 2024

Conversation

Saurabh-16
Copy link
Contributor

No description provided.

@Saurabh-16 Saurabh-16 requested a review from a team as a code owner October 17, 2024 08:40
@Saurabh-16 Saurabh-16 added the configs Label that generates configurations in automation repository label Oct 17, 2024
@pegaautomationuser
Copy link
Collaborator

Starting PR-837 validation on -> configs

@pegaautomationuser
Copy link
Collaborator

Starting PR-837 validation on -> configs

@pegaautomationuser
Copy link
Collaborator

Starting PR-837 validation on -> configs

@pegaautomationuser
Copy link
Collaborator

Starting PR-837 validation on -> configs

@pegaautomationuser
Copy link
Collaborator

Starting PR-837 validation on -> configs

kingakowalska1
kingakowalska1 requested changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@kingakowalska1 kingakowalska1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Saurabh,

Just a small suggestion. Please change the following text:

Starting from Kubernetes 1.29 version, kubernetes allows to set OS kernel level setting net.ipv4.tcp_keepalive_time using standard sysctls command.
Please refer below example and if needed, provide the value in seconds as per the cloud provider TCP connections timeout settings.

To:

Starting in Kubernetes version 1.29, you can configure the OS Kernel level setting net.ipv4.tcp_keepalive_time using standard sysctls command.
The following code provides an example configuration. If needed, provide the value in seconds as per the cloud provider TCP connections timeout settings.

Thanks!
Kinga

@pegaautomationuser
Copy link
Collaborator

Starting PR-837 validation on -> configs

kingakowalska1
kingakowalska1 approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@kingakowalska1 kingakowalska1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@APegaDavis
Copy link
Contributor

@Saurabh-16 is this only needed for runtime or should we be doing the same for the installer?

@Saurabh-16
Copy link
Contributor Author

Saurabh-16 commented Oct 22, 2024 •
edited
Loading

@Saurabh-16 is this only needed for runtime or should we be doing the same for the installer?
Hi @APegaDavis :- Currently its only for runtime use cases. This is a request from GOC as their TCP connections are timing out while making external server calls. Changes are extended to CMC and will be adopted in cloudk.

@Saurabh-16 Saurabh-16 merged commit 23b0df7 into pegasystems:master Oct 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kingakowalska1 kingakowalska1 kingakowalska1 approved these changes

@misterdorito misterdorito misterdorito approved these changes

@arvasrikanth arvasrikanth arvasrikanth approved these changes

@pega-talba pega-talba pega-talba approved these changes

Assignees
No one assigned
Labels
configs Label that generates configurations in automation repository
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Saurabh-16 @pegaautomationuser @APegaDavis @pega-talba @arvasrikanth @misterdorito @kingakowalska1