Build system #142
Build system #142
Conversation
| "*.min.js" | ||
| "*.min.js", | ||
| "build", | ||
| "rollup.config.js" // in .eslintrc-modules.js |
There was a problem hiding this comment.
If we start using more modules, we can add '*.mjs' here, and use the second call to eslint to get those also.
| - name: Test ${{ matrix.node-version }} | ||
| run: npm run test:bare | ||
| run: npm install && npm run build |
There was a problem hiding this comment.
npm build runs lint now.
| @@ -0,0 +1,38 @@ | |||
| { | |||
| "compilerOptions": { | |||
| "target": "es5", /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017', 'ES2018', 'ES2019', 'ES2020', or 'ESNEXT'. */ | |||
There was a problem hiding this comment.
Changing this from es6 to es5 is what makes this a babel replacement step. It makes the es6 output nearly useless however, so I removed that for the moment.
There was a problem hiding this comment.
oh, i forgot about this, sorry
it'd be best to emit them from separate paths through compilation. es5 and es6 end up substantially different in size and speed due to the shims and shams involved, and the es6 downstreams can do a better job of tree shaking when unshimmed
|
As I already said in #107, I do not like the way how it implemented. Splitting that to small, isolated steps will be better. Objections were @StoneCypher based on the fact that this is impossible (or very, very difficult). Looking at the final list of modified files in this PR, it seems highly exaggerated to me. There are, at least, many fixup commit, many of them just undoing changes from the previous commit(s). For example, commit, that adds Deletion of the node 10.x and addition it back in the next commit. The addition commit itself does too many work:
Some strange commits returning stuff, removed by the couple commits ago. Yet another round of throwing back and forth Clearly an experimental commit that shouldn't be in history. Fixup commits, yet another fixups I believe that upgrade can be made in more understandible way. If not decoupled into small pieces, than just in one commit that removes everything and another that adds the new infrastructure. |
|
I think the best I can do at this point is squash-merge 107 then drop this on top. I think that gets us to a better place than we were, and we can move forward from there. |
|
I'm going to follow the above plan in an hour or so unless anyone complains. |
|
... except I can't squash merge 107 since the original repo is private now. I'm tempted to just squash this whole thing, commit it as me, and make sure @StoneCypher still gets credit in the comments and release notes. |
|
I think I can add a Co-authored-by in the commit. |
… and npm build Adds Typescript, Rollup, Terser, and Jest. Author: John Haugeland <stonecypher@gmail.com>
|
OK, I think I got all of the commits squashed, and attributed to the right people (probably off by a line or two while i dealt with conflicts). I'm waiting for the tests to pass, then will take another look through to see if everything looks right. |
|
Everything looks good, I'm pulling the trigger. |
|
OK with that. If I had more time, I would have time to study the tools and would have tried to do what I described, but did not have time 🤷 |
This is a rework of #107. I simplified a few things, removed a few things that we're not using yet, and made sure that the web online, benchmark, and tests are using the new builds correctly. Web tests still use mocha for the moment, but getting Jest to work in the browser isn't trivial, and
jest-litedidn't work out of the box for me.