Extract the variable stack to a separate file and test it #157
Conversation
| * @return {string} Assignment code | ||
| */ | ||
| push(exprCode) { | ||
| const code = this.name(++this.sp) + " = " + exprCode + ";"; |
There was a problem hiding this comment.
Even though this is only used from generate-js at the moment, I was surprised to find JS code here. a) it makes it harder to see all of the JS code in one place b) it makes it harder to use this class for other languages later.
If you decide to do something about this, then this.type may or may not still be needed in the class.
There was a problem hiding this comment.
Actually, this class can be used by almost any C-like code generator: C/C++/C#/JS/Java. I'm not consider it as a public API right now, although
There was a problem hiding this comment.
OK, that makes sense. Later, if we want to be able to generate languages like Python, we can deal with type and semicolon being optional without breaking any code that relies on this interface.
| "use strict"; | ||
|
|
||
| class Stack { | ||
| constructor(ruleName, varName, type) { |
There was a problem hiding this comment.
constructor docs. for example, it wasn't clear that "type" could be "let".
| ); | ||
| }); | ||
| }); | ||
| }); |
Also this change add additional safety checks to the code generator and improves errors if they was violated
|
I've added missing documentation for |
Also this change add additional safety checks to the code generator and improves errors if they was violated