Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing argument in function call #170

Merged
merged 1 commit into from
Aug 12, 2021
Merged

Conversation

darlanalves
Copy link
Contributor

@darlanalves darlanalves commented Jul 3, 2021

When using es output format + Typescript, these functions calls cause a compilation error:

error TS2554: Expected 3 arguments, but got 2.

    55       const filler = peg$padEnd("", s.line.toString().length);
                                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

and

error TS2554: Expected 3 arguments, but got 2.

    61           + filler + " | " + peg$padEnd("", s.column - 1)
                                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~

@darlanalves
Copy link
Contributor Author

@Mingun ping

@hildjj
Copy link
Contributor

hildjj commented Jul 28, 2021

I think this is mine to fix. Assigning it to myself. Hopefully, I'll be able to pick back up working on peggy in a few days.

@hildjj hildjj self-assigned this Jul 28, 2021
@hildjj hildjj merged commit 3136b75 into peggyjs:main Aug 12, 2021
hildjj added a commit to hildjj/peggy that referenced this pull request Aug 15, 2021
… edge cases in the cli. Ensure that cli options are documented consistently. Make 'bare' a valid cli output type. Make multi-options all take comma-separated lists. Parser got generated with fix from peggyjs#170.  Ensure map files get cleaned up.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants