Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fixes in parser after my last PR and in tests #203

Merged
merged 2 commits into from
Oct 25, 2021
Merged

Small fixes in parser after my last PR and in tests #203

merged 2 commits into from
Oct 25, 2021

Conversation

Mingun
Copy link
Member

@Mingun Mingun commented Oct 22, 2021

Mingun added 2 commits October 22, 2021 23:04
@Mingun
Forgot to regenerate parser in the bd3798d
1f48de0
@Mingun
Check thrown exception using to.be.an.instanceof instead of to.throw
4670014 
This has two advantages:
- type checked before use
- if the `format()` result is incorrect, the test correctly fails on it.
  Previously a typeof assert generated (`AssertionError` vs `SyntaxError`)
@hildjj
Copy link
Contributor

hildjj commented Oct 25, 2021

I think the second one of these is still relevant?

@Mingun
Copy link
Member Author

Mingun commented Oct 25, 2021

Yes

@hildjj hildjj merged commit ed8316a into peggyjs:1.3 Oct 25, 2021
@Mingun Mingun deleted the fixes branch October 25, 2021 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mingun @hildjj