Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allowedStartRule of "*" means all #274

Merged
merged 4 commits into from
Jun 1, 2022
Merged

allowedStartRule of "*" means all #274

merged 4 commits into from
Jun 1, 2022

Conversation

hildjj
Copy link
Contributor

@hildjj hildjj commented Jun 1, 2022

This is in preparation for #243, and something I've needed several times. I've also fixed #229, because I'll want to use -S <rule> when developing the examples grammar.

Copy link
Member

@Mingun Mingun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference: this implements pegjs/pegjs#234

@@ -14,7 +14,12 @@ Released: TBD

### Minor Changes

- None
- [TBD] Use commander's new `.conflicts()` to check for mutually-exclusive CLI
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tip: I usually check the last PR/issue number on GitHub (there is continuous numbering) and set number in advance :). If do that just before push there is a high chance that number will be correct

@hildjj hildjj merged commit 74b70ad into peggyjs:main Jun 1, 2022
@hildjj hildjj deleted the all-starts branch June 1, 2022 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pass --startRule on the command line for testing
2 participants