-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor site into layouts #313
Conversation
Merge to main
Merge to main
Refactor site
Can we use 11ty version 2, even though it's not released quite yet? I'd rather not have to relearn stuff when they ship. |
It used to be that we could load the site from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest of this looks fine. I'm interested in response to my two other comments, though, before I merge.
I didn't realize there was a version 2 coming up. I'll look into, but given the framework position on backwards compatibility, I'm guessing it won't change much for us. |
If it's important, it's probably possible to get this working again. On the other hand, I think running a dev server is almost a necessity these days. Still, that's not an eleventy thing, I just made it absolute to make it easier to develop. |
It changes the config file at least with respect to how to configure browser-sync. I can make it work either way, but if we switch to v2 now, I won't have to re-figure that out when we upgrade. |
I will get around to updating this, just had some things come up, so I may not get to it until next week. |
@hildjj I updated the dev server config. It looks like it pulls in fewer dependencies now and is built-in to the framework. Otherwise, |
What this PR does
This PR adds some base/main layouts to the website, so that all pages can share common HTML, CSS, JS, etc.
Why I chose this approach
Breaking the site into layouts/components will make the site easier to maintain because content can be added independent of needing to keep the layout HTML/CSS updated. We can also update the CSS/JS for the whole website more easily.
This PR does not address any of the usability/accessibility issues in the site, or formatting issues. Those can be handled in a future PR.