Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor site into layouts #313

Merged
merged 18 commits into from
Jul 27, 2022
Merged

Refactor site into layouts #313

merged 18 commits into from
Jul 27, 2022

Conversation

camchenry
Copy link
Contributor

What this PR does

This PR adds some base/main layouts to the website, so that all pages can share common HTML, CSS, JS, etc.

Why I chose this approach

Breaking the site into layouts/components will make the site easier to maintain because content can be added independent of needing to keep the layout HTML/CSS updated. We can also update the CSS/JS for the whole website more easily.

This PR does not address any of the usability/accessibility issues in the site, or formatting issues. Those can be handled in a future PR.

@hildjj
Copy link
Contributor

hildjj commented Jul 8, 2022

Can we use 11ty version 2, even though it's not released quite yet? I'd rather not have to relearn stuff when they ship.

@hildjj
Copy link
Contributor

hildjj commented Jul 8, 2022

It used to be that we could load the site from file: URLs. With the absolute paths that we've changed to, that no longer works in the _site directory. This isn't a big deal now that we're mostly going to be running from browser-sync, I suppose. Just interested in discussing.

hildjj
hildjj previously approved these changes Jul 8, 2022
Copy link
Contributor

@hildjj hildjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest of this looks fine. I'm interested in response to my two other comments, though, before I merge.

@camchenry
Copy link
Contributor Author

Can we use 11ty version 2, even though it's not released quite yet? I'd rather not have to relearn stuff when they ship.

I didn't realize there was a version 2 coming up. I'll look into, but given the framework position on backwards compatibility, I'm guessing it won't change much for us.

@camchenry
Copy link
Contributor Author

It used to be that we could load the site from file: URLs. With the absolute paths that we've changed to, that no longer works in the _site directory. This isn't a big deal now that we're mostly going to be running from browser-sync, I suppose. Just interested in discussing.

If it's important, it's probably possible to get this working again. On the other hand, I think running a dev server is almost a necessity these days. Still, that's not an eleventy thing, I just made it absolute to make it easier to develop.

@hildjj
Copy link
Contributor

hildjj commented Jul 8, 2022

given the framework position on backwards compatibility, I'm guessing it won't change much for us.

It changes the config file at least with respect to how to configure browser-sync. I can make it work either way, but if we switch to v2 now, I won't have to re-figure that out when we upgrade.

@camchenry
Copy link
Contributor Author

I will get around to updating this, just had some things come up, so I may not get to it until next week.

@camchenry
Copy link
Contributor Author

@hildjj I updated the dev server config. It looks like it pulls in fewer dependencies now and is built-in to the framework. Otherwise, npm run start seems to work basically the same.

@hildjj hildjj merged commit 7c91272 into peggyjs:main Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants