Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make online version work in old browsers. #385

Merged
merged 4 commits into from
Mar 17, 2023
Merged

Conversation

hildjj
Copy link
Contributor

@hildjj hildjj commented Mar 16, 2023

Fixes #371.

}
#content #output {
overflow: auto;
max-height: 20em;
margin: 0; padding: .5em 1em; border: 2px solid silver; border-top: none;
background-color: #f0f0f0;
background-color: silver;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why exchange #f0f0f0 and silver? :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made the output colored, and it was easier to change the backgrounds so that yellow integers showed up than it was to figure out a different color for integers. I'm willing to turn colored output back off, or change the output colors if you'd prefer.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I meant that in the other place you changed silver to #f0f0f0 :)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway, it just seemed odd. If it was intentional, don't mind my comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would use #c0c0c0 for readability though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean #c0c0c0 instead of silver, right?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

depth: Infinity,
color: false,
maxArrayLength: Infinity,
maxStringLength: Infinity,
compact: false,
stylize: util.stylizeWithHTML,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the place where coloration was added.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and now I need to file a bug with node-inspect-extracted to HTML-escape output in stylizeWithHTML.

@hildjj
Copy link
Contributor Author

hildjj commented Mar 16, 2023

Depends on hildjj/node-inspect-extracted#22

@hildjj
Copy link
Contributor Author

hildjj commented Mar 17, 2023

OK, I think we're there. @polkovnikov-ph double check, please?

@hildjj hildjj merged commit baf7c45 into peggyjs:main Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error using online Peggy - Can't find variable: util
2 participants