-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make online version work in old browsers. #385
Conversation
docs/css/content.css
Outdated
} | ||
#content #output { | ||
overflow: auto; | ||
max-height: 20em; | ||
margin: 0; padding: .5em 1em; border: 2px solid silver; border-top: none; | ||
background-color: #f0f0f0; | ||
background-color: silver; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why exchange #f0f0f0
and silver
? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made the output colored, and it was easier to change the backgrounds so that yellow integers showed up than it was to figure out a different color for integers. I'm willing to turn colored output back off, or change the output colors if you'd prefer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I meant that in the other place you changed silver
to #f0f0f0
:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyway, it just seemed odd. If it was intentional, don't mind my comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would use #c0c0c0
for readability though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean #c0c0c0
instead of silver
, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
depth: Infinity, | ||
color: false, | ||
maxArrayLength: Infinity, | ||
maxStringLength: Infinity, | ||
compact: false, | ||
stylize: util.stylizeWithHTML, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the place where coloration was added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and now I need to file a bug with node-inspect-extracted to HTML-escape output in stylizeWithHTML.
Depends on hildjj/node-inspect-extracted#22 |
OK, I think we're there. @polkovnikov-ph double check, please? |
Fixes #371.