Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to using const wherever possible #41

Merged
merged 1 commit into from
Apr 16, 2021
Merged

Move to using const wherever possible #41

merged 1 commit into from
Apr 16, 2021

Conversation

hildjj
Copy link
Contributor

@hildjj hildjj commented Apr 15, 2021

Fixes #40

DO NOT MERGE until after 1.0 release

hildjj
hildjj commented Apr 15, 2021
View reviewed changes
Copy link
Contributor Author

@hildjj hildjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I double-checked that the only changes in this patch are let->const and the corresponding bundle changes. Tests still pass, but we should probably ensure there isn't a perf regression.

@hildjj hildjj force-pushed the const branch 2 times, most recently from 1b3bd62 to 139b361 Compare April 16, 2021 18:25
@hildjj hildjj marked this pull request as ready for review April 16, 2021 19:11
@hildjj
Copy link
Contributor Author

hildjj commented Apr 16, 2021

Ready to merge.

@hildjj hildjj mentioned this pull request Apr 16, 2021
Merged
@phpnode phpnode merged commit 2b2cf87 into peggyjs:main Apr 16, 2021
@hildjj hildjj deleted the const branch April 16, 2021 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phpnode phpnode phpnode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Turn on eslint prefer-const
2 participants
@hildjj @phpnode