Allow "constructor" and other object properties as grammar literals #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mingun
reviewed
Jun 19, 2024
Comment on lines
35
to
42
| "d = '__proto__'", | ||
| "e = 'constructor'", | ||
| "f = 'hasOwnProperty'", | ||
| "g = 'isPrototypeOf'", | ||
| "h = 'propertyIsEnumerable'", | ||
| "i = 'toLocaleString'", | ||
| "j = 'toString'", | ||
| "k = 'valueOf'", |
There was a problem hiding this comment.
Probably it is better to create a dedicated test with explicit intention to check that special properties are allowed.
There was a problem hiding this comment.
I'll squash the two last commits if this change works for you @Mingun
|
Puppeteer tests are broken again. I'm going to take a few minutes to switch to playwright, and get the web tests running headless, cross-browser, and in CI. |
Mingun
approved these changes
Jun 19, 2024
|
I did not test changes by myself, but they seems correct, so rely on CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #520.
The
Internclass uses an internal object to track whether a particular string has been seen before. It checks this withlet num = this.offsets[s];. If one of the 8 base properties ofObjectis used as the literal name,numgets a non-numeric result.The quick fix is to initialize
offsetswith an object that has no prototype instead of{}.