Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up rollup hacks. Fixes #531. #534

Merged
merged 1 commit into from
Jul 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ Released: TBD

### Bug fixes

- [#531](https://github.com/peggyjs/peggy/issues/531) Clean up rollup hacks
from CLI code.

### Documentation

4.0.3
Expand Down
37 changes: 0 additions & 37 deletions bin/peggy-cli.js
Original file line number Diff line number Diff line change
Expand Up @@ -736,43 +736,6 @@ class PeggyCLI extends Command {
return this.run();
}
}

// For some reason, after running through rollup, typescript can't see
// methods from the base class.

/**
* @param {string[]} [argv] - optional, defaults to process.argv
* @param {Object} [parseOptions] - optionally specify style of options with from: node/user/electron
* @param {string} [parseOptions.from] - where the args are from: 'node', 'user', 'electron'
* @return {PeggyCLI} `this` command for chaining
*/
parse(argv, parseOptions) {
return super.parse(argv, parseOptions);
}

/**
* @param {Object} [configuration] - configuration options
* @return {PeggyCLI} `this` command for chaining, or stored configuration
*/
configureHelp(configuration) {
return super.configureHelp(configuration);
}

/**
* @param {Object} [configuration] - configuration options
* @return {PeggyCLI} `this` command for chaining, or stored configuration
*/
configureOutput(configuration) {
return super.configureOutput(configuration);
}

/**
* @param {Function} [fn] optional callback which will be passed a CommanderError, defaults to throwing
* @return {PeggyCLI} `this` command for chaining
*/
exitOverride(fn) {
return super.exitOverride(fn);
}
}

exports.PeggyCLI = PeggyCLI;