Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mjs plugins #535

Merged
merged 4 commits into from
Jul 7, 2024
Merged

Mjs plugins #535

merged 4 commits into from
Jul 7, 2024

Conversation

hildjj
Copy link
Contributor

@hildjj hildjj commented Jul 6, 2024

Fixes #530

@hildjj
Copy link
Contributor Author

hildjj commented Jul 6, 2024

TODO: test with ts-pegjs before merging. @metadevpro might want to double-check as well.

@hildjj hildjj mentioned this pull request Jul 6, 2024
Closed
@hildjj
Copy link
Contributor Author

hildjj commented Jul 7, 2024

Todo: Don't import if the config.js has already import/required the plugin.

@hildjj
Copy link
Contributor Author

hildjj commented Jul 7, 2024

Todo: Don't import if the config.js has already import/required the plugin.

That is already done and tested.

@hildjj
Copy link
Contributor Author

hildjj commented Jul 7, 2024

I didn't test with ts-pegjs because of metadevpro/ts-pegjs#122, but I'm pretty sure it's going to work after looking at the code and adding a small tweak to the loader to support (await import('ts-pegjs')).default.use.

@hildjj hildjj merged commit 0d1c4f3 into peggyjs:main Jul 7, 2024
10 checks passed
@hildjj hildjj deleted the mjs-plugin branch July 9, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow es6 plugins from CLI
1 participant
@hildjj