Check for missing parent object in confidence score computation #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orangejulius
approved these changes
Sep 25, 2017
| res += propMatch(text.state, (hit.parent.region_a ? hit.parent.region_a[0] : null), true); | ||
| res += propMatch(text.country, (hit.parent.country_a ? hit.parent.country_a[0] :null), true); | ||
| res += propMatch(text.state, ((hit.parent && hit.parent.region_a) ? hit.parent.region_a[0] : null), true); | ||
| res += propMatch(text.country, ((hit.parent && hit.parent.country_a) ? hit.parent.country_a[0] :null), true); |
There was a problem hiding this comment.
subtle hint to @trescube that refactoring all this code to use lodash _.get would be amazing :P
There was a problem hiding this comment.
indeed, not only a hint to @trescube but rather to the whole team
There was a problem hiding this comment.
I singled out @trescube because i know he has no greater joy in life than refactoring code to use lodash :P
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been experiences a significant number of these errors recently.
500 Cannot read property 'region_a' of undefinedFor example: /v1/search?debug=true&layers=neighbourhood&text=cuba, new me