feat(coarse_reverse): ignore empty abbr properties from PIP service #1010
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from #1003 ...
In 1003 I added code to
try/catch
the document construction code (to avoid the service crashing), thanks to @gitsno I was able to see that the true culprits are responses like this:This PR ignores empty
abbr
attributes (ie:abbr=''
) and so will not cause a fatal error now unless the name itself is invalid.As a result, the API will no longer return an empty resultset for cases where the PIP service returns results with an empty abbr property.
closes #1009