Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(coarse_reverse): ignore empty abbr properties from PIP service #1010

Merged
merged 1 commit into from
Sep 28, 2017

Conversation

missinglink
Copy link
Member

Following on from #1003 ...

In 1003 I added code to try/catch the document construction code (to avoid the service crashing), thanks to @gitsno I was able to see that the true culprits are responses like this:

"id":85632733,
"name":"Somaliland",
"abbr":""

This PR ignores empty abbr attributes (ie: abbr='') and so will not cause a fatal error now unless the name itself is invalid.

As a result, the API will no longer return an empty resultset for cases where the PIP service returns results with an empty abbr property.

closes #1009

Copy link
Contributor

@trescube trescube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@missinglink missinglink merged commit e24b899 into master Sep 28, 2017
@ghost ghost removed the in progress label Sep 28, 2017
@orangejulius orangejulius deleted the coarse_reverse_try_catch branch November 14, 2017 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception crashes the API service
3 participants