Remove focus_selected_layers query view #1162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This query extends the standard focus query view with hardcoded layers for which the query applies. The intent was to apply the focus scoring only to non-admin areas, but the list of layers was already out of date, as it was missing streets. The query is fundamentally problematic with custom layers as well.
orangejulius
force-pushed
the
remove_focus_selected_layers
branch
from
cbb8249 to
561f079
Compare
missinglink
approved these changes
Jun 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "focus selected layers" query was used in the autocomplete endpoint and extends the standard focus query view with hard-coded layers for which the query applies. I'm guessing the original intent was to apply the focus scoring only to non-admin areas, but the list of layers was already out of date, as it was missing streets.
The query is fundamentally problematic with custom layers as well.
I can imagine that there could be problems sorting administrative areas relative to a focus point, but I can also see it being very desirable and something that would currently not be possible with the logic in this query.
While it's tempting to change the query to support custom layers and preserve whatever behavior is obtained by not sorting admin areas by distance, I think it's worth experimenting with the query deleted completely, and normal focus sorting applied.
Connects #1161