Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in libpostal when parsing AUS unit numbers, as per pelias/pelias#753
The PR assumes that the order of forward-slash delimited address numerals is in the order
{unit}/{house number}
. I did some checking online and consulted https://en.wikipedia.org/wiki/Address_(geography) and it seems to be a fairly safe bet.You can do a
ctrl+f
on that wiki page and search forslash
, the only other countries listed as possibly having a slash areCzech Republic
andSlovakia
.In both of those cases, the slash represents an addressing scheme which we don't currently support, so I think that the change will be hugely positive for Australia while having no real negative impact elsewhere.
The PR is in 4 parts:
resolves: pelias/pelias#753