improved deduping across languages #1228
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
following on from #1222 this PR changes two behaviours:
improved matching across languages
The previous code would cycle through all the names in
item1
and first do a key-check onitem2
, only if the key also existed in the second item, it would then compare values, if they differed then the two items were considered different.The issue with that approach is something like this, which is considered different:
The new code does it differently, instead it first cycles through all the values in
item2
, comparing them toitem1.default
, then it cycles through all the values initem1
and compares them toitem2.default
.So it's essentially saying "If any of the language values matched the default value of the other item, consider them as a dupe"
[edit] I added another commit which now also considers the user agent language for comparison on top of the
default
.matching on aliases
We were only matching on the first item in an array of values, this code uses slightly more CPU but it considers all aliases in deduplication.