Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out null island results #163

Closed
stevage opened this issue Aug 25, 2017 · 4 comments
Closed

Filter out null island results #163

stevage opened this issue Aug 25, 2017 · 4 comments

Comments

@stevage
Copy link

stevage commented Aug 25, 2017

For whatever reason, Mapzen's geocoder is returning a lot of results whose geometry is [0,0]. Showing these results as autocomplete suggestions is pretty poor UX, and undermines user confidence in the geocoder.

For instance, typing "bl" gives this:

screen shot 2017-08-25 at 1 48 26 pm

Apart from the 3 results from Switzerland, the other 7 results are all null island.

@dianashk
Copy link
Contributor

Hey @stevage, great catch! We missed a check for null island records in our openaddresses importer. Will add it shortly. Thanks for your feedback!

@dianashk
Copy link
Contributor

This has been fixed! 🎉 🎉 Thanks again for reporting the issue.

screen shot 2017-09-15 at 12 37 52 pm

@stevage
Copy link
Author

stevage commented Sep 16, 2017 via email

@dianashk
Copy link
Contributor

@stevage, no we actually had a code change go through in a linked PR. No changes to the user interface of leaflet-geocoder or the API were made, however.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants