Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filter out records with lat/lon both parseable as 0 #277

Merged
merged 1 commit into from
Aug 30, 2017
Merged

filter out records with lat/lon both parseable as 0 #277

merged 1 commit into from
Aug 30, 2017

Conversation

trescube
Copy link
Contributor

Fixes #276 and therefore pelias/leaflet-plugin#163

@trescube trescube self-assigned this Aug 30, 2017
@trescube trescube added this to the API Improvements milestone Aug 30, 2017
orangejulius
orangejulius approved these changes Aug 30, 2017
View reviewed changes
Copy link
Member

@orangejulius orangejulius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Thinking more long term, don't we have a check like this in other importers? I wonder if the time is growing near for us to build a set of common importer tools to validate lat/lons, country codes, and other things.

@trescube
Copy link
Contributor Author

We should probably filter out addresses that are in water, too.

@trescube trescube merged commit d2bbac3 into master Aug 30, 2017
@trescube trescube deleted the filter-out-null-island-addresses branch August 30, 2017 15:46
@dianashk dianashk mentioned this pull request Sep 19, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orangejulius orangejulius orangejulius approved these changes

@missinglink missinglink Awaiting requested review from missinglink

@dianashk dianashk Awaiting requested review from dianashk

Assignees

@trescube trescube

Labels
in review
Projects
None yet
Milestone
API Improvements
Development

Successfully merging this pull request may close these issues.
2 participants
@trescube @orangejulius