Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validate config starting at root element, not subelement #211

Merged
merged 2 commits into from
Jan 12, 2017
Merged

validate config starting at root element, not subelement #211

merged 2 commits into from
Jan 12, 2017

Conversation

trescube
Copy link
Contributor

validate was being called with the root whereas the function itself was working off of the imports.openaddresses element.

@trescube trescube added this to the API Improvements milestone Jan 11, 2017
@trescube trescube self-assigned this Jan 11, 2017
orangejulius
orangejulius approved these changes Jan 11, 2017
View reviewed changes
Copy link
Member

@orangejulius orangejulius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@trescube trescube merged commit 5c40daf into master Jan 12, 2017
@trescube trescube deleted the validate-config-from-root branch January 12, 2017 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dianashk dianashk dianashk approved these changes

@orangejulius orangejulius orangejulius approved these changes

@missinglink missinglink Awaiting requested review from missinglink

Assignees

@trescube trescube

Labels
None yet
Projects
None yet
Milestone
API Improvements
Development

Successfully merging this pull request may close these issues.
3 participants
@trescube @orangejulius @dianashk