Skip to content

Commit

Permalink
Merge pull request #184 from pelias/nodejs-18-and-ci-updates
Browse files Browse the repository at this point in the history
CI updates: Modern Node.js versions, action version updates, standard template
  • Loading branch information
orangejulius authored Dec 3, 2024
2 parents a9930dd + ce44123 commit de12b13
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 13 deletions.
12 changes: 5 additions & 7 deletions .github/workflows/_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,18 +6,16 @@ jobs:
strategy:
matrix:
os:
- ubuntu-20.04
node-version:
- 12.x
- 14.x
- 16.x
- ubuntu-22.04
node-version: [ 18.x, 20.x ]
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: 'Install node.js ${{ matrix.node-version }}'
uses: actions/setup-node@v2-beta
uses: actions/setup-node@v4
with:
node-version: '${{ matrix.node-version }}'
- name: Run unit tests
run: |
[[ -f ./bin/ci-setup ]] && ./bin/ci-setup
npm install
npm run ci
12 changes: 6 additions & 6 deletions .github/workflows/push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,13 @@ jobs:
npm-publish:
needs: unit-tests
if: github.ref == 'refs/heads/master' && needs.unit-tests.result == 'success'
runs-on: ubuntu-20.04
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: Install Node.js
uses: actions/setup-node@v2-beta
uses: actions/setup-node@v4
with:
node-version: 16.x
node-version: 20.x
- name: Run semantic-release
env:
GH_TOKEN: ${{ secrets.GH_SEMANTIC_RELEASE_TOKEN }}
Expand All @@ -26,9 +26,9 @@ jobs:
# note: github actions won't run a job if you don't call one of the status check functions, so `always()` is called since it evalutes to `true`
if: ${{ always() && needs.unit-tests.result == 'success' && (needs.npm-publish.result == 'success' || needs.npm-publish.result == 'skipped') }}
needs: [unit-tests, npm-publish]
runs-on: ubuntu-20.04
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: Build Docker images
env:
DOCKER_USERNAME: ${{ secrets.DOCKER_USERNAME }}
Expand Down

0 comments on commit de12b13

Please sign in to comment.