Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using pip-service for admin lookup during builds creates invalid hierarchcies on geonames records #220

Open
orangejulius opened this issue Aug 1, 2018 · 0 comments

Comments

@orangejulius
Copy link
Member

When using the pip-service (rather than in-memory WOF polygons in the importer itself) to do admin lookup, Geonames records are being assigned administrative areas at all levels of the hierarchy. So for example, a county will be given an admin locality, which is not correct.

This leads to incorrect labels, such as this case:
http://pelias.github.io/compare/#/v1/search%3Fsources=geonames&layers=localadmin&size=1&text=city%20of%20new%20york
screen shot 2018-08-01 at 5 07 47 pm

Basically, it appears the code in https://github.com/pelias/wof-admin-lookup/blob/master/src/getAdminLayers.js which was specifically designed to handle this, is not being applied.

orangejulius added a commit to pelias/acceptance-tests that referenced this issue Aug 1, 2018
orangejulius added a commit to pelias/acceptance-tests that referenced this issue Aug 1, 2018
orangejulius added a commit to pelias/acceptance-tests that referenced this issue Jan 17, 2019
orangejulius added a commit to pelias/acceptance-tests that referenced this issue Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant