Skip to content

Commit

Permalink
Revert "Also call mkl_sycl_destructor before deleting SYCL queue (Jul…
Browse files Browse the repository at this point in the history
…iaGPU#420)"

This reverts commit 89d5df6.
  • Loading branch information
pengtu committed Apr 15, 2024
1 parent 07285be commit 91ed2a5
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
3 changes: 1 addition & 2 deletions deps/src/onemkl.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -4234,10 +4234,9 @@ extern "C" int onemklXsparse_matmat(syclQueue_t device_queue, matrix_handle_t A,

// oneMKL keeps a cache of SYCL queues and tries to destroy them when unloading the library.
// that is incompatible with oneAPI.jl destroying queues before that, so call mkl_free_buffers
// and mkl_sycl_destructor to manually cleanup oneMKL cache when we're destroying queues.
// to manually wipe the device cache when we're destroying queues.

extern "C" int onemklDestroy() {
mkl_free_buffers();
mkl_sycl_destructor();
return 0;
}
1 change: 0 additions & 1 deletion deps/src/onemkl.h
Original file line number Diff line number Diff line change
Expand Up @@ -2574,7 +2574,6 @@ int onemklXsparse_matmat(syclQueue_t device_queue, matrix_handle_t A, matrix_han
matrix_handle_t C, onemklMatmatRequest req, matmat_descr_t
descr, int64_t *sizeTempBuffer, void *tempBuffer);

void mkl_sycl_destructor(void);
int onemklDestroy(void);
#ifdef __cplusplus
}
Expand Down

0 comments on commit 91ed2a5

Please sign in to comment.