Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default auto field #23

Merged
merged 4 commits into from
Jul 24, 2023
Merged

Conversation

progremir
Copy link
Contributor

  • fix(models): add missing migrations #22 was redundant, cause the migration you added before was due to django 4.1 introducing new default auto field (BigAutoField).
  • so in the current version of django-trackstats folks who use it inside django >= 4.0 will be seeing:
    Your models in app(s): 'trackstats' have changes that are not yet reflected in a migration, and so won't be applied.
      Run 'manage.py makemigrations' to make new migrations, and then re-run 'manage.py migrate' to apply them.
    
  • while the rest will be fine
  • this settings set this field in stone for this application and no further migrations will be needed after it's applied
  • @pennersr tho we can still change it to fit the new django de-facto BigAutoField, wdyt?

@pennersr
Copy link
Owner

Defaulting to BigAutoField would be better indeed.

@progremir
Copy link
Contributor Author

@pennersr done. tho checks are failing. any tips on how to fix them? can't see what exactly went wrong

@progremir
Copy link
Contributor Author

@pennersr what's up bro, what do you say?

@pennersr
Copy link
Owner

@pennersr done. tho checks are failing. any tips on how to fix them? can't see what exactly went wrong

You need to add these to the config:

    name = "trackstats"
    verbose_name = "TrackStats"

@progremir
Copy link
Contributor Author

@pennersr sorry for the wait, done

@pennersr
Copy link
Owner

Sorry for nitpicking, but can you make sure that the code is black formatted? The build is failing because it is currently not properly formatted.

@progremir
Copy link
Contributor Author

Sure @pennersr, done.

@pennersr pennersr merged commit dfd1677 into pennersr:master Jul 24, 2023
@progremir progremir deleted the set-default-auto-field branch July 25, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants