Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test with up-to-date dependencies #18

Merged
merged 6 commits into from
Jul 24, 2023
Merged

Update test with up-to-date dependencies #18

merged 6 commits into from
Jul 24, 2023

Conversation

greeeg
Copy link
Contributor

@greeeg greeeg commented Jul 22, 2023

Description

This PR updates our frontend test to have up-to-date dependencies to work with.

Axios version resolution is forced to 0.27.2 as create-react-app v5 does not resolve cjs files correctly (see facebook/create-react-app#11889). One solution could be to use vite instead of CRA.

There are also warnings about source maps which are suppressed by the GENERATE_SOURCEMAP=false env variable (see facebook/create-react-app#11752).

@greeeg greeeg self-assigned this Jul 22, 2023
@greeeg greeeg marked this pull request as ready for review July 22, 2023 08:42
@greeeg greeeg requested review from tdeo and quentindemetz July 22, 2023 08:42
Copy link
Contributor

@maximebiloe maximebiloe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@greeeg greeeg merged commit 9ccb5e3 into main Jul 24, 2023
@greeeg greeeg deleted the gm/update-test branch July 24, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants