Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arkworks feature requires u64_backend #107

Open
redshiftzero opened this issue Jul 18, 2024 · 1 comment · May be fixed by #108
Open

arkworks feature requires u64_backend #107

redshiftzero opened this issue Jul 18, 2024 · 1 comment · May be fixed by #108

Comments

@redshiftzero
Copy link
Member

Currently in the decaf377 repository the following should work:

  • No default features, using the u32_backend (for hardware wallets)
  • Default features, using the u32_backend,r1cs features (for WASM)

However, when r1cs is enabled, arkworks is enabled, which incorrectly forces the use of the u64_backend: https://github.com/penumbra-zone/decaf377/blob/main/src/fields/fp.rs#L16

Discovered in: penumbra-zone/web#1492

@redshiftzero redshiftzero changed the title arkworks feature implicitly requires u64_backend arkworks feature requires u64_backend Jul 18, 2024
@redshiftzero
Copy link
Member Author

The default 64-bit field arithmetic backend requires the "optional" feature arkworks, which is why the build without default features (i.e. without arkworks) in #108 are currently failing CI

One path forward is to make the 32-bit backend become the default (i.e. adding a u64_backend feature and bumping major release versions) since it doesn't have the arkworks feature requirement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant